Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22583 )
Change subject: IMPALA-13825: Extend Docker container build to custom base images ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22583/6/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/22583/6/bin/start-impala-cluster.py@1034 PS6, Line 1034: env_args += ["-e", "TZ={0}".format(timezone_string)] > Is it possible to directly mount os.path.realpath("/etc/localtime") into th I tried it, but it runs into the same sequencing problem inside the container as I experienced on the host: - /etc/localtime is a symlink defined inside the container, pointing to /usr/share/zoneinfo/UTC, setting up a default timezone - when the mount happens, the symlink reference is resolved first, then the resolved path is passed in to the mount() call - the result is that the passed-in timezone file gets bind-mounted over /usr/share/zoneinfo/UTC, effectively overwriting timezone data for UTC, while /etc/localtime remains a symlink pointing to it - this can be seen in /proc/mounts (showing just the relevant line): /dev/nvme0n1p4 /usr/share/zoneinfo/UTC xfs rw,relatime,attr2,inode64,logbufs=8,logbsize=32k,noquota 0 0 In the end this causes various tests to fail with symptoms pointing to time zone desynchronization between the host and the container. I'd be happy to explore this, but I'd prefer to do that in a follow-up patch: this works now with various base containers and with various host timezones (UTC, America/Los_Angeles and Europe/Budapest were tested). -- To view, visit http://gerrit.cloudera.org:8080/22583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e39f399664fe66f3774caa316ed5d4df24befc Gerrit-Change-Number: 22583 Gerrit-PatchSet: 6 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Mar 2025 21:40:19 +0000 Gerrit-HasComments: Yes
