Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22583 )
Change subject: IMPALA-13825: Extend Docker container build to custom base images ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/22583/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22583/1//COMMIT_MSG@33 PS1, Line 33: - USE_HARDENED_IMPALA_BASE_IMAGE: : If set to 'true', triggers the use of the custom image. : When set to 'false' or left unspecified, the Docker base image is : selected by the existing logic of matching the build platform's : operating system. : - IMPALA_HARDENED_DOCKER_BASE: specifies the URI of the base image I didn't see these env vars in the patch - maybe these are from a different version? http://gerrit.cloudera.org:8080/#/c/22583/1/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/daemon_entrypoint.sh@194 PS1, Line 194: export LC_ALL=C.UTF-8 Is this intentional? It overrides the setting from previous block. http://gerrit.cloudera.org:8080/#/c/22583/1/docker/impala_base/Dockerfile File docker/impala_base/Dockerfile: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/impala_base/Dockerfile@33 PS1, Line 33: # RUN --mount=type=bind,source=helper/install_os_packages.sh,target=/root/os_packages.sh \ : # /root/os_packages.sh ${INSTALL_OS_PACKAGES_ARGS} is this left here by mistake? http://gerrit.cloudera.org:8080/#/c/22583/1/docker/impala_profile_tool/Dockerfile File docker/impala_profile_tool/Dockerfile: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/impala_profile_tool/Dockerfile@34 PS1, Line 34: # RUN --mount=type=bind,source=helper/install_os_packages.sh,target=/root/os_packages.sh \ : # /root/os_packages.sh ${INSTALL_OS_PACKAGES_ARGS} ? http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh File docker/install_os_packages.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh@128 PS1, Line 128: elif [[ -f /sbin/apk && -x /sbin/apk ]]; then : echo "Indentified Wolfi-based system." Why does this indicate Chainguard? Is it the only system with apk? The log message could indicate this. -- To view, visit http://gerrit.cloudera.org:8080/22583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e39f399664fe66f3774caa316ed5d4df24befc Gerrit-Change-Number: 22583 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Mar 2025 12:40:30 +0000 Gerrit-HasComments: Yes
