Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22656 )
Change subject: IMPALA-13885: Add Query Id to Workload Management Insert Logs ...................................................................... IMPALA-13885: Add Query Id to Workload Management Insert Logs When the workload management code inserts rows into the completed queries table, it logs an entry with information on that insert but does not include the query id in the log line. This lack of query id causes extra steps to trace cases where the insert DML failed. This change adds the query id to both the success and failure log messages logged by the workload management main processing loop. It also adds the error message to the failure log messages. Additional minor cleanup was done to provide error messages on python custom cluster test asserts, add additional asserts for the updated log messages, and restore a trailing newline in the workload management startup flags definition file. All test_query_log.py tests passed locally. These tests were the only tests that asserted the log messages that were modified. Change-Id: I3c0816f9eb6bac8c891fd0e249de8863115bf466 Reviewed-on: http://gerrit.cloudera.org:8080/22656 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/service/workload-management-worker.cc M be/src/workload_mgmt/workload-management-flags.cc M tests/custom_cluster/test_query_log.py 3 files changed, 57 insertions(+), 25 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3c0816f9eb6bac8c891fd0e249de8863115bf466 Gerrit-Change-Number: 22656 Gerrit-PatchSet: 10 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com>
