Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22656 )
Change subject: IMPALA-13885: Add Query Id to Workload Management Insert Logs ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22656/6/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/22656/6/tests/custom_cluster/test_query_log.py@583 PS6, Line 583: # When a workload management insert DML fails, a warning message is logged that : # contains information about the DML. These two assertions ensure the message is : # logged and important fields are correct. : res = self.assert_impalad_log_contains( : level="WARNING", : line_regex=r'failed to write completed queries table="{}" record_count=1 ' : r'bytes=\S+\s\S+ gather_time=\S+ > I could not get placeholders to work on multi-line strings. I now realize Ack http://gerrit.cloudera.org:8080/#/c/22656/7/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/22656/7/tests/custom_cluster/test_query_log.py@588 PS7, Line 588: record_count=1 record_count can be validated separately just like msg. -- To view, visit http://gerrit.cloudera.org:8080/22656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c0816f9eb6bac8c891fd0e249de8863115bf466 Gerrit-Change-Number: 22656 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 24 Mar 2025 23:23:15 +0000 Gerrit-HasComments: Yes
