Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22571 )
Change subject: IMPALA-13684: Improve waitForHmsEvent() to only wait for related events ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/22571/7/fe/src/main/java/org/apache/impala/analysis/SingleTableStmt.java File fe/src/main/java/org/apache/impala/analysis/SingleTableStmt.java: http://gerrit.cloudera.org:8080/#/c/22571/7/fe/src/main/java/org/apache/impala/analysis/SingleTableStmt.java@1 PS7, Line 1: package org.apache.impala.analysis; Need Apache license header here? http://gerrit.cloudera.org:8080/#/c/22571/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/22571/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1578 PS7, Line 1578: waitForSyncUpToFreshMetadata nit: I think waitForMostRecentMetadata sounds better. http://gerrit.cloudera.org:8080/#/c/22571/7/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/22571/7/tests/authorization/test_ranger.py@1983 PS7, Line 1983: --hms_event_polling_interval_s=5 Instead of setting long polling interval, can you pause/resume EP using command from IMPALA-12785? http://gerrit.cloudera.org:8080/#/c/22571/7/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22571/7/tests/common/impala_test_suite.py@1516 PS7, Line 1516: def run_with_hms_sync(cls, client, timeout_s=10, strict=True): This is unused? -- To view, visit http://gerrit.cloudera.org:8080/22571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic033b7e197cd19505653c3ff80c4857cc474bcfc Gerrit-Change-Number: 22571 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 19:22:03 +0000 Gerrit-HasComments: Yes
