Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: IMPALA-13657: Connect Calcite planner to Impala Frontend framework ...................................................................... Patch Set 24: Code-Review+1 (2 comments) This is looking good to me http://gerrit.cloudera.org:8080/#/c/22319/24/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22319/24/fe/src/main/java/org/apache/impala/service/Frontend.java@2342 PS24, Line 2342: return !(Parser.parse(queryCtx.client_request.stmt) instanceof QueryStmt); Nit: I think we should use the Parser.parse() signature that also passes in the query options. I can't tell if it really matters, but let's pretend that it might. http://gerrit.cloudera.org:8080/#/c/22319/18/tests/query_test/test_calcite_planner.py File tests/query_test/test_calcite_planner.py: http://gerrit.cloudera.org:8080/#/c/22319/18/tests/query_test/test_calcite_planner.py@29 PS18, Line 29: class TestCalcitePlanner(ImpalaTestSuite): > Ah, I tested it with the environment variable USE_CALCITE_PLANNER=true whic Let's keep this as a custom cluster test until we fix running Calcite tests as regular tests. It looks like bin/start-impala-cluster.py has an "-env_vars" argument that could pass in USE_CALCITE_PLANNER=true. -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 24 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Mar 2025 21:53:25 +0000 Gerrit-HasComments: Yes
