Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22634 )
Change subject: IMPALA-13850: Wait until CatalogD active before resetting metadata ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/22634/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22634/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2307 PS3, Line 2307: LOG.info("skip blacklisted db: " + dbName); > Can we add a debug_action before this to sleep for a while to minic the slo Done. Added test_catalogd_auto_failover_slow to test it. http://gerrit.cloudera.org:8080/#/c/22634/2/tests/custom_cluster/test_catalogd_ha.py File tests/custom_cluster/test_catalogd_ha.py: http://gerrit.cloudera.org:8080/#/c/22634/2/tests/custom_cluster/test_catalogd_ha.py@179 PS2, Line 179: assert 1000 >= int(statestore_service.get_flag_current_value( : 'active_catalogd_designation_monitoring_interval_ms')) > Trying to understand why we need sync_ddl=1 in the test. Maybe just use it Added query test that should fail if coordinator has not receive update from StatestoreD about the standby_catalogd becomes active. This can be flaky if statestored is fast, so I make both statestore_heartbeat_frequency_ms and active_catalogd_designation_monitoring_interval_ms to be at least 1s. http://gerrit.cloudera.org:8080/#/c/22634/3/tests/custom_cluster/test_catalogd_ha.py File tests/custom_cluster/test_catalogd_ha.py: http://gerrit.cloudera.org:8080/#/c/22634/3/tests/custom_cluster/test_catalogd_ha.py@102 PS3, Line 102: > int: is Done -- To view, visit http://gerrit.cloudera.org:8080/22634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cc66dcccedb306ff11893f2916ee5ee6a3efc1 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Mar 2025 18:05:32 +0000 Gerrit-HasComments: Yes
