Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22634 )
Change subject: IMPALA-13850: Wait until CatalogD active before resetting metadata ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22634/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22634/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2307 PS3, Line 2307: for (String dbName: allDbs) { Can we add a debug_action before this to sleep for a while to minic the slowness in this method (and the write lock of versionLock_ is held)? http://gerrit.cloudera.org:8080/#/c/22634/2/tests/custom_cluster/test_catalogd_ha.py File tests/custom_cluster/test_catalogd_ha.py: http://gerrit.cloudera.org:8080/#/c/22634/2/tests/custom_cluster/test_catalogd_ha.py@179 PS2, Line 179: # Kill active catalogd : active_catalogd.kill() > Queries run before standby catalogd becomes active will fail. See test_cata Trying to understand why we need sync_ddl=1 in the test. Maybe just use it to introduce a configurable delay? It seems no tests run the query after the active catalogd is killed and before the standby becomes active. They both run the query before killing the active catalogd. But I might miss something. -- To view, visit http://gerrit.cloudera.org:8080/22634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cc66dcccedb306ff11893f2916ee5ee6a3efc1 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Mar 2025 12:02:07 +0000 Gerrit-HasComments: Yes
