Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22280 )
Change subject: IMPALA-13566: Expose query cancellation status to UDFs ...................................................................... Patch Set 13: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22280/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22280/13//COMMIT_MSG@22 PS13, Line 22: 200ms Maybe, alongside also include the name of the constant like (i.e. SLEEP_UNINTERRUPTIBLE_MS). http://gerrit.cloudera.org:8080/#/c/22280/13//COMMIT_MSG@28 PS13, Line 28: HS2Connection The name of the class seems a little generic compared to others, if possible, consider making it a little more specific. Unless this is better suited for future use cases. http://gerrit.cloudera.org:8080/#/c/22280/13/be/src/exprs/utility-functions-ir.cc File be/src/exprs/utility-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/22280/13/be/src/exprs/utility-functions-ir.cc@38 PS13, Line 38: using namespace std; Please consider if the namespace is necessary, if it's only for chrono, consider "using std::chrono;" here. -- To view, visit http://gerrit.cloudera.org:8080/22280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9430167f7e46bbdf66153abb4645541cd8cf0142 Gerrit-Change-Number: 22280 Gerrit-PatchSet: 13 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 13 Mar 2025 12:24:32 +0000 Gerrit-HasComments: Yes
