Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22280 )
Change subject: IMPALA-13566: Expose query cancellation status to UDFs ...................................................................... Patch Set 12: (5 comments) > Patch Set 8: > > (5 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22280/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22280/8//COMMIT_MSG@22 PS8, Line 22: 200ms. This means that we only ne > mentioning the actual time periods seems more useful than the constant name Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/22280/8/be/src/exprs/utility-functions-ir.cc File be/src/exprs/utility-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/22280/8/be/src/exprs/utility-functions-ir.cc@40 PS8, Line 40: 00}; > Maybe use a bit smaller one, e.g. 200ms? Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/22280/8/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22280/8/tests/common/impala_connection.py@691 PS8, Line 691: ) > this could have a try/catch block (+log) to close the connection even if cl Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/22280/8/tests/common/impala_connection.py@727 PS8, Line 727: > maybe use a bigger default timeout? wait_for_admission_control uses 60sec Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/22280/8/tests/common/impala_connection.py@748 PS8, Line 748: if async_cursor: > the name looks misleading, as this waits for the state and not just tells w Thanks! Changed to use wait_for() in test_interrupt_sleep(). Is that OK? -- To view, visit http://gerrit.cloudera.org:8080/22280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9430167f7e46bbdf66153abb4645541cd8cf0142 Gerrit-Change-Number: 22280 Gerrit-PatchSet: 12 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 13 Mar 2025 10:38:55 +0000 Gerrit-HasComments: Yes
