Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22617 )

Change subject: IMPALA-13842: Standardize workload management tests
......................................................................


Patch Set 1:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22617/1/tests/common/wm_test_suite.py
File tests/common/wm_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/22617/1/tests/common/wm_test_suite.py@20
PS1, Line 20: from signal import SIGRTMIN
flake8: F401 'signal.SIGRTMIN' imported but unused


http://gerrit.cloudera.org:8080/#/c/22617/1/tests/custom_cluster/test_workload_mgmt_sql_details.py
File tests/custom_cluster/test_workload_mgmt_sql_details.py:

http://gerrit.cloudera.org:8080/#/c/22617/1/tests/custom_cluster/test_workload_mgmt_sql_details.py@418
PS1, Line 418: class 
TestWorkloadManagementSQLDetailsCalcite(WorkloadManagementTestSuite):
flake8: E302 expected 2 blank lines, found 1



--
To view, visit http://gerrit.cloudera.org:8080/22617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6452fa963304e263805ebeb017c843d17dd16
Gerrit-Change-Number: 22617
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Mar 2025 21:05:35 +0000
Gerrit-HasComments: Yes

Reply via email to