Jason Fehr has uploaded a new patch set (#2) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/22617 )
Change subject: IMPALA-13842: Standardize workload management tests ...................................................................... IMPALA-13842: Standardize workload management tests This patch standardizes tests against system tables (sys.impala_query_log and sys.impala_query_live) to use a common superclass named WorkloadManagementTestSuite. The setup_method of this superclass waits for workload management init completion (wait_for_wm_init_complete()), while the teardown_method waits until impala-server.completed-queries.queued metric reaches 0 (wait_for_wm_idle()). test_query_log.py, test_query_live.py and test_workload_mgmt_sql_details.py are refactored to extend from WorkloadManagementTestSuite. Tests to assert the query log table flush behavior are grouped together in TestQueryLogTableFlush. test_workload_mgmt_init.py does not extend from WorkloadManagementTestSuite because it is testing cluster start and restart scenario. This patch only adds wait_for_wm_idle() at teardown_method where it make sense to do so. workload_mgmt parameter in CustomClusterTestSuite.with_args() is standardized to setup appropriate default flags in cluster_setup() rather than passing it down to _start_impala_cluster(): IMPALAD_ARGS '--enable_workload_mgmt=true --query_log_write_interval_s=1' and CATALOGD_ARGS '--enable_workload_mgmt=true' Note that IMPALAD_ARGS and CATALOGD_ARGS flags added by workload_mgmt and impalad_graceful_shutdown parameter are still overridable to different value by explicitly adding it in the impalad_args and catalogd_args parameters. Setting workload_mgmt=True should also be followed by setting impalad_graceful_shutdown=True whenever possible. Additionally, print total wait time in wait_for_metric_value(). Testing: - Run modified tests and pass. Change-Id: Iecf6452fa963304e263805ebeb017c843d17dd16 --- M be/src/service/workload-management-worker.cc M tests/common/custom_cluster_test_suite.py M tests/common/impala_cluster.py M tests/common/impala_service.py A tests/common/wm_test_suite.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_query_live.py M tests/custom_cluster/test_query_log.py M tests/custom_cluster/test_workload_mgmt_init.py M tests/custom_cluster/test_workload_mgmt_sql_details.py 10 files changed, 444 insertions(+), 421 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/22617/2 -- To view, visit http://gerrit.cloudera.org:8080/22617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iecf6452fa963304e263805ebeb017c843d17dd16 Gerrit-Change-Number: 22617 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
