Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22409 )
Change subject: IMPALA-13042: Calcite Planner; Enable partition pruning ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22409/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java: http://gerrit.cloudera.org:8080/#/c/22409/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java@102 PS5, Line 102: private static class ConjunctsHelper { > This class seems kind of arbitrary. Why doesn't separateConjuncts populate So my reasoning was: 1) Sorta felt natural to me to say, "hey, I'm doing more than a one-liner to fill these final member variables, this should be in a separate function." 2) Both member variables had to be filled up at the same time 3) I sometimes use the "Pair" class, but I just don't really like it that much. Given that it is kinda small-ish, I guess I can understand some disdain for doing it this way. I just put the code in the base class, it really doesn't detract from readability that way. -- To view, visit http://gerrit.cloudera.org:8080/22409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c698b857555baeae347835b4a6b39d035f12405 Gerrit-Change-Number: 22409 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Mar 2025 02:35:12 +0000 Gerrit-HasComments: Yes
