Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22409 )
Change subject: IMPALA-13042: Calcite Planner; Enable partition pruning ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22409/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22409/4//COMMIT_MSG@9 PS4, Line 9: Enables partition pruning in the HdfsScan RelNode. > What is the visible outcome of this change? It produces different plans whe Yes, and there are tests in the Impala test framework that check for partition pruning, so no additional testing is needed. http://gerrit.cloudera.org:8080/#/c/22409/4/fe/src/main/java/org/apache/impala/planner/HdfsPartitionFilter.java File fe/src/main/java/org/apache/impala/planner/HdfsPartitionFilter.java: http://gerrit.cloudera.org:8080/#/c/22409/4/fe/src/main/java/org/apache/impala/planner/HdfsPartitionFilter.java@123 PS4, Line 123: Expr literalPredicate = predicate_.substitute(sMap, analyzer, true); > Why did this change? Was it an existing bug? I tested this months ago, so I can't quite remember which query caused the problem, but the Calcite planner did not like it when the root type changed. I also tested this with a full run on Jenkins on the existing planner and all tests passed. So I think it makes sense to make this change. http://gerrit.cloudera.org:8080/#/c/22409/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java: http://gerrit.cloudera.org:8080/#/c/22409/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/PrunedPartitionHelper.java@60 PS4, Line 60: // TODO: tblref is null. Tablesampling is disabled. > Is there an existing ticket for this? Filed IMPALA-13849 -- To view, visit http://gerrit.cloudera.org:8080/22409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c698b857555baeae347835b4a6b39d035f12405 Gerrit-Change-Number: 22409 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Mar 2025 23:23:19 +0000 Gerrit-HasComments: Yes
