Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22588 )
Change subject: IMPALA-13812: Fail query for certain errors related to AI functions ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc File be/src/exprs/ai-functions.cc: http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc@83 PS4, Line 83: return copyErrorMessage(ctx, _status.msg().msg()); \ If we're setting the error status of the FunctionContext, can we return StringVal::null()? Is retuning error as results mainly required for tests? We could also update the unit tests to compare with FunctionContext::error_msg(). http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc@262 PS4, Line 262: // Return a string with the invalid prompt error message instead of failing I think this should be a SQL error because prompt is added by the user and cannot be null or empty. http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc@347 PS4, Line 347: return copyErrorMessage(ctx, status.ToString()); Same question here, we could return StringVal::null() unless we need the return value for unit tests. -- To view, visit http://gerrit.cloudera.org:8080/22588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639e48e64d62f7990cf9a3c35a59a0ee3a2c64e0 Gerrit-Change-Number: 22588 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 10 Mar 2025 21:04:20 +0000 Gerrit-HasComments: Yes
