Abhishek Rawat has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22588 )

Change subject: IMPALA-13812: Fail query for certain errors related to AI 
functions
......................................................................


Patch Set 2:

(1 comment)

Please also update the expr tests we recently added. These queries should now 
CATCH an error instead of returning results. Also, would be good to move these 
to their own tests

https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/exprs.test#L3392-L3412

We can create a new test under TestExprs class for parquet as the test itself 
is not dependent on format.
https://github.com/apache/impala/blob/master/tests/query_test/test_exprs.py#L36

http://gerrit.cloudera.org:8080/#/c/22588/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22588/2//COMMIT_MSG@10
PS2, Line 10: returns
return



--
To view, visit http://gerrit.cloudera.org:8080/22588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I639e48e64d62f7990cf9a3c35a59a0ee3a2c64e0
Gerrit-Change-Number: 22588
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 06 Mar 2025 23:04:39 +0000
Gerrit-HasComments: Yes

Reply via email to