Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: IMPALA-13657: Connect Calcite planner to Impala Frontend framework ...................................................................... Patch Set 13: (1 comment) This should be further reviewed after https://gerrit.cloudera.org/#/c/22591/ http://gerrit.cloudera.org:8080/#/c/22319/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java: http://gerrit.cloudera.org:8080/#/c/22319/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@60 PS11, Line 60: } : : private static final String PLANNER = "Calcite > I would like to remove these fields so that the compiler factory is statele As you probably already saw on some other commits, some major plumbing has been changed and this comment has been addressed. -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 13 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Sat, 08 Mar 2025 18:13:09 +0000 Gerrit-HasComments: Yes
