Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: IMPALA-13657: Connect Calcite planner to Impala Frontend framework ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/22319/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java: http://gerrit.cloudera.org:8080/#/c/22319/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@60 PS11, Line 60: private CalciteParsedStatement parsedStatement_; : : private CalciteAnalysisDriver analysisDriver_; I would like to remove these fields so that the compiler factory is stateless. I think it is doable with a bit of plumbing. CalciteAnalysisDriver doesn't need parsedStatement_ until analyze(). At that point, it can get it from the AnalysisResult, which has been constructed by then. The PlannerContext has access to the AnalysisResult. To avoid the analysisDriver_ field, CalciteSingleNodePlanner would need to be able to get the AnalysisDriver out of AnalysisResult. Am I understanding that right? -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Mar 2025 22:46:51 +0000 Gerrit-HasComments: Yes
