Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: WIP: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 7: (47 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22527/7/be/src/util/network-util.h File be/src/util/network-util.h: http://gerrit.cloudera.org:8080/#/c/22527/7/be/src/util/network-util.h@47 PS7, Line 47: Status HostnameToIpAddr(const Hostname& hostname, IpAddr* ip, bool ipv6=false) WARN_UNUSED_RESULT; line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22527/7/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/22527/7/be/src/util/network-util.cc@92 PS7, Line 92: result = inet_ntop(AF_INET6, &((sockaddr_in6*)it->ai_addr)->sin6_addr, addr_buf, 64); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22527/7/be/src/util/network-util.cc@96 PS7, Line 96: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22527/7/be/src/util/network-util.cc@99 PS7, Line 99: ss << "Could not convert IPv" << (is_ipv6_addr ? 6: 4) << "address for: " << hostname; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22527/7/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22527/7/shell/impala_shell.py@1005 PS7, Line 1005: flake8: E222 multiple spaces after operator http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/custom_cluster_test_suite.py@609 PS7, Line 609: flake8: W292 no newline at end of file http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_cluster.py@561 PS7, Line 561: r flake8: E111 indentation is not a multiple of 2 http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_service.py@80 PS7, Line 80: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_service.py@483 PS7, Line 483: c flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_test_suite.py@372 PS7, Line 372: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_test_suite.py@372 PS7, Line 372: _ flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_test_suite.py@494 PS7, Line 494: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/impala_test_suite.py@1781 PS7, Line 1781: c flake8: U100 Unused argument 'cls' http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/network.py File tests/common/network.py: http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/network.py@36 PS7, Line 36: def split_host_port(host_port): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/network.py@48 PS7, Line 48: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/network.py@48 PS7, Line 48: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/network.py@49 PS7, Line 49: def to_host_port(host, port): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22527/7/tests/common/network.py@54 PS7, Line 54: CERT_TO_CA_MAP = { flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py File tests/custom_cluster/test_ipv6.py: http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@24 PS7, Line 24: import re flake8: F401 're' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@26 PS7, Line 26: import signal flake8: F401 'signal' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@27 PS7, Line 27: import ssl flake8: F401 'ssl' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@28 PS7, Line 28: import socket flake8: F401 'socket' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@29 PS7, Line 29: import sys flake8: F401 'sys' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@30 PS7, Line 30: import time flake8: F401 'time' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@32 PS7, Line 32: from tests.common.environ import IS_REDHAT_DERIVATIVE flake8: F401 'tests.common.environ.IS_REDHAT_DERIVATIVE' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@34 PS7, Line 34: from tests.common.impala_service import ImpaladService flake8: F401 'tests.common.impala_service.ImpaladService' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@37 PS7, Line 37: from tests.shell.util import run_impala_shell_cmd, run_impala_shell_cmd_no_expect, \ flake8: F401 'tests.shell.util.run_impala_shell_cmd_no_expect' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@37 PS7, Line 37: from tests.shell.util import run_impala_shell_cmd, run_impala_shell_cmd_no_expect, \ flake8: F401 'tests.shell.util.ImpalaShell' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@61 PS7, Line 61: R flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@62 PS7, Line 62: R flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@73 PS7, Line 73: flake8: E241 multiple spaces after ':' http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@80 PS7, Line 80: flake8: E241 multiple spaces after ':' http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@87 PS7, Line 87: class TestIPv6Base(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@103 PS7, Line 103: i flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@133 PS7, Line 133: i flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@146 PS7, Line 146: e flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@153 PS7, Line 153: U flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@179 PS7, Line 179: U flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@206 PS7, Line 206: L flake8: E501 line too long (131 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@207 PS7, Line 207: W flake8: E501 line too long (104 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@208 PS7, Line 208: D flake8: E501 line too long (101 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@237 PS7, Line 237: Y flake8: E501 line too long (131 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@238 PS7, Line 238: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@238 PS7, Line 238: W flake8: E501 line too long (104 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@239 PS7, Line 239: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@239 PS7, Line 239: D flake8: E501 line too long (101 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/7/tests/custom_cluster/test_ipv6.py@251 PS7, Line 251: flake8: E241 multiple spaces after ',' -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Sat, 08 Mar 2025 17:40:21 +0000 Gerrit-HasComments: Yes
