Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: WIP: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 6: (51 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/util/network-util.h File be/src/util/network-util.h: http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/util/network-util.h@47 PS6, Line 47: Status HostnameToIpAddr(const Hostname& hostname, IpAddr* ip, bool ipv6=false) WARN_UNUSED_RESULT; line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/util/network-util.cc@92 PS6, Line 92: result = inet_ntop(AF_INET6, &((sockaddr_in6*)it->ai_addr)->sin6_addr, addr_buf, 64); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/util/network-util.cc@96 PS6, Line 96: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/util/network-util.cc@99 PS6, Line 99: ss << "Could not convert IPv" << (is_ipv6_addr ? 6: 4) << "address for: " << hostname; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22527/6/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/22527/6/bin/bootstrap_system.sh@521 PS6, Line 521: if ! [[ 1 = $(sudo -u postgres psql -At -c "SELECT count(*) FROM pg_roles WHERE rolname = 'hiveuser';") ]] line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/custom_cluster_test_suite.py@613 PS6, Line 613: flake8: W292 no newline at end of file http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_cluster.py@561 PS6, Line 561: r flake8: E111 indentation is not a multiple of 2 http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_service.py@80 PS6, Line 80: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_service.py@483 PS6, Line 483: c flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_test_suite.py@374 PS6, Line 374: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_test_suite.py@374 PS6, Line 374: t flake8: E501 line too long (101 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_test_suite.py@496 PS6, Line 496: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/impala_test_suite.py@1773 PS6, Line 1773: c flake8: U100 Unused argument 'cls' http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/network.py File tests/common/network.py: http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/network.py@36 PS6, Line 36: def split_host_port(host_port): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/network.py@48 PS6, Line 48: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/network.py@48 PS6, Line 48: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/network.py@49 PS6, Line 49: def to_host_port(host, port): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22527/6/tests/common/network.py@54 PS6, Line 54: CERT_TO_CA_MAP = { flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_client_ssl.py@203 PS6, Line 203: . flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_client_ssl.py@224 PS6, Line 224: . flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py File tests/custom_cluster/test_ipv6.py: http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@24 PS6, Line 24: import re flake8: F401 're' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@26 PS6, Line 26: import signal flake8: F401 'signal' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@27 PS6, Line 27: import ssl flake8: F401 'ssl' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@28 PS6, Line 28: import socket flake8: F401 'socket' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@29 PS6, Line 29: import sys flake8: F401 'sys' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@30 PS6, Line 30: import time flake8: F401 'time' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@32 PS6, Line 32: from tests.common.environ import IS_REDHAT_DERIVATIVE flake8: F401 'tests.common.environ.IS_REDHAT_DERIVATIVE' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@34 PS6, Line 34: from tests.common.impala_service import ImpaladService flake8: F401 'tests.common.impala_service.ImpaladService' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@36 PS6, Line 36: from tests.common.test_dimensions import create_client_protocol_dimension flake8: F401 'tests.common.test_dimensions.create_client_protocol_dimension' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@37 PS6, Line 37: from tests.shell.util import run_impala_shell_cmd, run_impala_shell_cmd_no_expect, \ flake8: F401 'tests.shell.util.run_impala_shell_cmd' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@37 PS6, Line 37: from tests.shell.util import run_impala_shell_cmd, run_impala_shell_cmd_no_expect, \ flake8: F401 'tests.shell.util.run_impala_shell_cmd_no_expect' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@37 PS6, Line 37: from tests.shell.util import run_impala_shell_cmd, run_impala_shell_cmd_no_expect, \ flake8: F401 'tests.shell.util.ImpalaShell' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@37 PS6, Line 37: from tests.shell.util import run_impala_shell_cmd, run_impala_shell_cmd_no_expect, \ flake8: F401 'tests.shell.util.create_impala_shell_executable_dimension' imported but unused http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@45 PS6, Line 45: class TestIPv6(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@58 PS6, Line 58: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@58 PS6, Line 58: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@60 PS6, Line 60: I flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@64 PS6, Line 64: _ flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@65 PS6, Line 65: _ flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@74 PS6, Line 74: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@79 PS6, Line 79: @ flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@129 PS6, Line 129: @ flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@129 PS6, Line 129: U flake8: E501 line too long (133 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@130 PS6, Line 130: L flake8: E501 line too long (106 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@131 PS6, Line 131: I flake8: E501 line too long (103 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@152 PS6, Line 152: N flake8: E501 line too long (133 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@153 PS6, Line 153: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@153 PS6, Line 153: S flake8: E501 line too long (107 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@154 PS6, Line 154: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@154 PS6, Line 154: W flake8: E501 line too long (104 > 90 characters) http://gerrit.cloudera.org:8080/#/c/22527/6/tests/custom_cluster/test_ipv6.py@201 PS6, Line 201: # flake8: E265 block comment should start with '# ' -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Mar 2025 12:10:04 +0000 Gerrit-HasComments: Yes
