Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22407 )
Change subject: IMPALA-12588: Don't UPDATE rows that already have the desired value ...................................................................... Patch Set 10: (3 comments) Left some minor comments, after this I'm ready to +2 http://gerrit.cloudera.org:8080/#/c/22407/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22407/10//COMMIT_MSG@65 PS10, Line 65: ( invalid parentheses in sample statement, also in L68 http://gerrit.cloudera.org:8080/#/c/22407/10//COMMIT_MSG@92 PS10, Line 92: ) invalid parentheses, also in L85, plus the next line is unaligned http://gerrit.cloudera.org:8080/#/c/22407/10/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test: http://gerrit.cloudera.org:8080/#/c/22407/10/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test@391 PS10, Line 391: ---- TYPES Shouldn't we check RUNTIME_PROFILE for this statement? -- To view, visit http://gerrit.cloudera.org:8080/22407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I926c80e8110de5a4615a3624a81a330f54317c8b Gerrit-Change-Number: 22407 Gerrit-PatchSet: 10 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 17:09:51 +0000 Gerrit-HasComments: Yes
