Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22407 )
Change subject: IMPALA-12588: Don't UPDATE rows that already have the desired value ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/22407/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22407/9//COMMIT_MSG@98 PS9, Line 98: -46% Shouldn't this be -54%? http://gerrit.cloudera.org:8080/#/c/22407/9//COMMIT_MSG@98 PS9, Line 98: 4.1 What is the unit here? http://gerrit.cloudera.org:8080/#/c/22407/9/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: http://gerrit.cloudera.org:8080/#/c/22407/9/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@169 PS9, Line 169: sqlString_ = toSql(); Is it intentional that 'sqlString_' is calculated earlier than before the patch? -- To view, visit http://gerrit.cloudera.org:8080/22407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I926c80e8110de5a4615a3624a81a330f54317c8b Gerrit-Change-Number: 22407 Gerrit-PatchSet: 9 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 08:50:33 +0000 Gerrit-HasComments: Yes
