Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22546/4/testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test File testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test: http://gerrit.cloudera.org:8080/#/c/22546/4/testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test@288 PS4, Line 288: IMPALA=SUCCESS Did you check that this failed before your fix? Looks like it uses `explain select`, which seems like it should be sufficient. http://gerrit.cloudera.org:8080/#/c/22546/4/tests/metadata/test_views_compatibility.py File tests/metadata/test_views_compatibility.py: http://gerrit.cloudera.org:8080/#/c/22546/4/tests/metadata/test_views_compatibility.py@134 PS4, Line 134: ) > flake8: E501 line too long (91 > 90 characters) Still has a flake8 warning. -- To view, visit http://gerrit.cloudera.org:8080/22546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198 Gerrit-Change-Number: 22546 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 22:16:10 +0000 Gerrit-HasComments: Yes
