Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22546 )
Change subject: IMPALA-13786: Skip rewriting expr of Hive auto-generated label ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py File tests/metadata/test_views_compatibility.py: http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@125 PS3, Line 125: if creator_engine == HIVE: : invalidate_query = "invalidate metadata {0}".format(test_case.hive_view_name) : engine_to_exec[IMPALA](invalidate_query, create_query, None) Running the test manually, I'm still seeing redundant Invalidate query. I'll tidy this up in next patch set. http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@139 PS3, Line 139: select_query > Can we double check here "if explain_query == select_query"? Then if yes, w Ack http://gerrit.cloudera.org:8080/#/c/22546/3/tests/metadata/test_views_compatibility.py@173 PS3, Line 173: > nit. no need extra line The extra line addresses flake8 error: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/22546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b8bbd0afd6da0532bf2ef460989d4f01337d198 Gerrit-Change-Number: 22546 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:56:56 +0000 Gerrit-HasComments: Yes
