Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22535 )
Change subject: IMPALA-13789: Defer creating Path objects in loading file metadata ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java: http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@a506 PS2, Line 506: > By "keying off getLocation", do you mean passing in tbl.getSd() (StorageDes I was just looking into whether Path might do some normalization that might result in two different location Strings being equal. http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@384 PS2, Line 384: // by this code path. However, DirectMetaProvider is not yet a supported feature. > Removed this. The MetaException is replaced with CatalogException in Ack -- To view, visit http://gerrit.cloudera.org:8080/22535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ec1fc932eaf7c833ef6ee6cdb08bba235e38271 Gerrit-Change-Number: 22535 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 00:17:31 +0000 Gerrit-HasComments: Yes
