Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22535 )
Change subject: IMPALA-13789: Defer creating Path objects in loading file metadata ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java: http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@a506 PS2, Line 506: It looks like Path didn't automatically normalize the URL, so I think keying off getLocation will be fine. http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@184 PS2, Line 184: Path partPath = FileSystemUtil.createFullyQualifiedPath(new Path(partDir_)); Did we call createFullyQualifiedPath somewhere else before? Looks like ParallelFileMetadataLoader did. http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/22535/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@384 PS2, Line 384: //TODO(IMPALA-9042): Remove "throws MetaException" Do we still need this TODO? -- To view, visit http://gerrit.cloudera.org:8080/22535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ec1fc932eaf7c833ef6ee6cdb08bba235e38271 Gerrit-Change-Number: 22535 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 19:18:28 +0000 Gerrit-HasComments: Yes
