Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/22456 )
Change subject: IMPALA-13739: Part2: Introduce IcebergFileDescriptor ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22456/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java: http://gerrit.cloudera.org:8080/#/c/22456/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java@33 PS3, Line 33: FbFileMetadata > Why would it be a breaking change? Is it in case of zero-downtime upgrades? Yes, I meant the zero-downtime upgrades. What I found that makes this a bit more difficult is that scan ranges are expected to have THdfsFileDesc (see toThrift() here) and there is no inheritance with thrift structs. So I don't think we can change that structure so we'd need to use FbFileMetadata anyway when converting this to thrift. I prefer to keep this change small enough now, and later on some further investigation could be done to get rid of FbFileMetadata. http://gerrit.cloudera.org:8080/#/c/22456/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java@90 PS3, Line 90: == > In its previous place this code was in the same class where encoding and de Sure, done -- To view, visit http://gerrit.cloudera.org:8080/22456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id08baf4db32197bab74178777c4ba3fec98c2451 Gerrit-Change-Number: 22456 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 10:26:57 +0000 Gerrit-HasComments: Yes
