Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22456 )

Change subject: IMPALA-13739: Part2: Introduce IcebergFileDescriptor
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22456/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java
File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java:

http://gerrit.cloudera.org:8080/#/c/22456/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@306
PS1, Line 306:         hdfsFileDesc = 
FeIcebergTable.Utils.getHdfsFileDescriptor(contentFile, icebergTable);
line too long (93 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id08baf4db32197bab74178777c4ba3fec98c2451
Gerrit-Change-Number: 22456
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 06 Feb 2025 17:34:16 +0000
Gerrit-HasComments: Yes

Reply via email to