Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22423 )
Change subject: IMPALA-13674: Enable MERGE statement for Iceberg tables with equality deletes ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Thanks for the fix! http://gerrit.cloudera.org:8080/#/c/22423/3/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java: http://gerrit.cloudera.org:8080/#/c/22423/3/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@340 PS3, Line 340: write Nit: could add: write/read http://gerrit.cloudera.org:8080/#/c/22423/3/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@342 PS3, Line 342: new SlotRef( Nit: this could come on the previous line, to have matching indentation with the next add() on L345. http://gerrit.cloudera.org:8080/#/c/22423/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/22423/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java@a530 PS3, Line 530: Instead of deleting it, this test could be converted into a "positive" test with AnalyzesOk(). -- To view, visit http://gerrit.cloudera.org:8080/22423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60e48e2731a59520373dbb75104d75aae39a94c1 Gerrit-Change-Number: 22423 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2025 14:24:00 +0000 Gerrit-HasComments: Yes
