Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22423 )
Change subject: IMPALA-13674: Enable MERGE statement for Iceberg tables with equality deletes ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22423/2/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/22423/2/tests/query_test/test_iceberg.py@2006 PS2, Line 2006: nit: we use +4 indent http://gerrit.cloudera.org:8080/#/c/22423/2/tests/query_test/test_iceberg.py@2008 PS2, Line 2008: warehouse_prefix=os.getenv("DEFAULT_FS")) Does this test work on Ozone? http://gerrit.cloudera.org:8080/#/c/22423/2/tests/util/iceberg_metadata_util.py File tests/util/iceberg_metadata_util.py: http://gerrit.cloudera.org:8080/#/c/22423/2/tests/util/iceberg_metadata_util.py@115 PS2, Line 115: # Remove unneccessary parts if the table location differs from : # the default location nit: could you please provide an example? -- To view, visit http://gerrit.cloudera.org:8080/22423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60e48e2731a59520373dbb75104d75aae39a94c1 Gerrit-Change-Number: 22423 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2025 17:41:39 +0000 Gerrit-HasComments: Yes
