Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22474 )
Change subject: WIP IMPALA-11597: Unset impala.lastComputeStatsTime during DROP STATS ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG@7 PS1, Line 7: WIP IMPALA-11597: Unset impala.lastComputeStatsTime during DROP STATS : > Title can be shorter. For example: Ack http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG@11 PS1, Line 11: TATS t PARTITION (partition_spec)' : > Is there any test that validate this statement? I haven't found one. We can't do it here since iceberg does not support 'incremental' variants. There is also 'compute-stats-*.test' family of tests, among which DROP INCREMENTAL STATS is tested, but I don't see test cases for any 'impala.lastComputeStatsTime' scenario there. So it's probably non consistent to add a test just for this scenario alone. Especially given that we do not change the previous behavior here. http://gerrit.cloudera.org:8080/#/c/22474/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22474/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2824 PS1, Line 2824: boolean droppedLastCompute = : msTbl.getParameters().remove(HdfsTable.TBL_PROP_LAST_COMPUTE_STATS_TIME) != null; > Will 'impala.lastComputeStatsTime' removal raise HMS event? If yes, what wi Seems like it doesn't in this case. There is 'TestEventProcessingWithImpala.test_self_events_with_impala' which was falling for one of my previous patches and passes for this code. But I haven't looked really deeply into the whole events mechanism yet, let me know if you think this is still error-prone. http://gerrit.cloudera.org:8080/#/c/22474/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/22474/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@266 PS1, Line 266: '','numRows ','2 > Add validation that 'totalSize' is also gone. Ok, not directly related, but can do. -- To view, visit http://gerrit.cloudera.org:8080/22474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id743bc9779141df7a26a95a0ea201ef6fc6aeff9 Gerrit-Change-Number: 22474 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2025 13:47:34 +0000 Gerrit-HasComments: Yes
