Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22438 )
Change subject: IMPALA-13724: Add hostnames for Docker host and gateway to Impala containers ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22438/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/22438/1/bin/start-impala-cluster.py@1021 PS1, Line 1021: internal_listen_host = os.environ["INTERNAL_LISTEN_HOST"] > Oh, I completely agree on how configurability should be set up, that wasn't Oh, nevermind; I went down a completely wrong path; scratch all my previous statements. I built all my arguments around the hostname part of the mapping; for some reason I haven't noticed that your comment was actually about the IP address part, which is taken from the encironment variable. There is a very specific reason for pulling the IP address mapping for local_gateway_arg from that environment variable. It is not just a convenient default value: the mapping supplied to the "docker run ..." command line actually needs to contain exactly that value. That environment variable is set up in https://github.com/apache/impala/blob/master/docker/configure_test_network.sh#L45 and https://github.com/apache/impala/blob/master/docker/configure_test_network.sh#L51, and it holds the exact IP address assigned by the Docker runtime to the gateway interface (to be) inserted into the Impala containers. The whole patch is about to ensure that that specific IP address can be successfully resolved to a hostname during Thrift connection attempts. In other words the goal of this patch is that the hostname mapped to that IP address: 1. exists, i.e. can be resolved by a reverse lookup by Thrift during its connection attempts 2. is guaranteed not to contain and underscore character, which causes the Thrift connection attempt to fail. This means that the IP address part should _not_ be configurable; it must match the Docker-determined gateway address exactly. Retrieving it from the environment variable is just a convenient shortcut from having to call Docker again in a way similar to https://github.com/apache/impala/blob/master/docker/configure_test_network.sh#L45 -- To view, visit http://gerrit.cloudera.org:8080/22438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I545607c0bb32f8043a0d3f6045710f28a47bab99 Gerrit-Change-Number: 22438 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2025 18:26:40 +0000 Gerrit-HasComments: Yes
