Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22438 )
Change subject: IMPALA-13724: Add hostnames for Docker host and gateway to Impala containers ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22438/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/22438/1/bin/start-impala-cluster.py@1044 PS1, Line 1044: + > I suspect we should disable this check as it doesn't match to our existing I'll raise a separate patch for critique-gerrit-review.py about this. PEP8 changed their opinion about this back in 2016, see https://www.flake8rules.com/rules/W504.html, which explains why a log of Python code in Impala follows the older rule about this. -- To view, visit http://gerrit.cloudera.org:8080/22438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I545607c0bb32f8043a0d3f6045710f28a47bab99 Gerrit-Change-Number: 22438 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 22:44:41 +0000 Gerrit-HasComments: Yes
