Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor webUI scripts to use ES6 syntax ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21851/6/www/query_finstances.tmpl File www/query_finstances.tmpl: http://gerrit.cloudera.org:8080/#/c/21851/6/www/query_finstances.tmpl@107 PS6, Line 107: if (toggle.getElementById("toogle").checked === true) { : interval_id = setInterval(refresh, 1000); : document.getElementById("refresh_on").textContent = "Auto-refresh on"; > Can you elaborate in commit message why this some getElementById() is gone I had updated the commit message and had put back getElementById as it might be better in long term to not rely on browser based global variable declarations. I had overlooked some of them. I have corrected it now. -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 7 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Feb 2025 11:13:57 +0000 Gerrit-HasComments: Yes
