Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor webUI scripts to use ES6 syntax ...................................................................... Patch Set 6: (2 comments) Thanks. I have now re-written the commit message to better encompass the changes. http://gerrit.cloudera.org:8080/#/c/21851/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21851/5//COMMIT_MSG@30 PS5, Line 30: in uppercase. : -> All other types of variables have been declared using snake case. : : This naming scheme allows easier distinction between functions, : constants and other varia > Is this naming scheme changes required by ES6 standard? I can pre-enforce the rules from IMPALA-13473 to match here or switch the order of patches. There are also other rules within ESLint. http://gerrit.cloudera.org:8080/#/c/21851/5/www/admission_controller.tmpl File www/admission_controller.tmpl: http://gerrit.cloudera.org:8080/#/c/21851/5/www/admission_controller.tmpl@149 PS5, Line 149: const POOL_NAME = json[pool_idx]['pool_name']; : const histogram = json[pool_idx]["peak_mem_usage_histogram"]; > Why one constant is uppercase and the other constant is lower case? I was naming primitive value constants with upper case, and other variables with lower snake case, for easier distinction from identifiers. -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Feb 2025 20:13:34 +0000 Gerrit-HasComments: Yes
