Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22165 )
Change subject: IMPALA-13648: Implement a decoder and an encoder for Byte Stream Split encoding ...................................................................... Patch Set 27: (12 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-coder-test-data.h File be/src/exec/parquet/parquet-byte-stream-split-coder-test-data.h: http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-coder-test-data.h@26 PS27, Line 26: // https://github.com/apache/parquet-java/blob/1de2af8b8b7dc86af120da7c0ce3e43453ea98dc/parquet-column/src/test/java/org/apache/parquet/column/values/bytestreamsplit/ByteStreamSplitValuesReaderTest.java line too long (202 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-decoder.h File be/src/exec/parquet/parquet-byte-stream-split-decoder.h: http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-decoder.h@25 PS27, Line 25: // (https://github.com/apache/parquet-format/blob/master/Encodings.md#byte-stream-split-byte_stream_split--9) line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-encoder.h File be/src/exec/parquet/parquet-byte-stream-split-encoder.h: http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-encoder.h@26 PS27, Line 26: // (https://github.com/apache/parquet-format/blob/master/Encodings.md#byte-stream-split-byte_stream_split--9) line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc File be/src/exec/parquet/parquet-byte-stream-split-test.cc: http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@142 PS27, Line 142: ParquetByteStreamSplitDecoder<BYTE_SIZE> decoder = createDecoder<BYTE_SIZE>(runtime_byte_size); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@873 PS27, Line 873: encode_then_decode_with_stride<sizeof(double)>(double_decoded_200v, sizeof(double) + 1, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@875 PS27, Line 875: encode_then_decode_with_stride<sizeof(double)>(double_decoded_200v, sizeof(double) + 2, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@877 PS27, Line 877: encode_then_decode_with_stride<sizeof(double)>(double_decoded_200v, sizeof(double) + 3, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@879 PS27, Line 879: encode_then_decode_with_stride<sizeof(double)>(double_decoded_200v, sizeof(double) * 3, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@883 PS27, Line 883: encode_then_decode_with_stride<sizeof(double)>(double_decoded_200v, sizeof(double) + 1, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@885 PS27, Line 885: encode_then_decode_with_stride<sizeof(double)>(double_decoded_200v, sizeof(double) + 2, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@887 PS27, Line 887: encode_then_decode_with_stride<sizeof(double)>(double_decoded_200v, sizeof(double) + 3, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22165/27/be/src/exec/parquet/parquet-byte-stream-split-test.cc@889 PS27, Line 889: encode_then_decode_with_stride<sizeof(double)>(double_decoded_200v, sizeof(double) * 3, line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icea60894ae22b8ddb7616aeda6d69012cc69972c Gerrit-Change-Number: 22165 Gerrit-PatchSet: 27 Gerrit-Owner: Gabriella Gyorgyevics <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabriella Gyorgyevics <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2025 17:14:40 +0000 Gerrit-HasComments: Yes
