Gabriella Gyorgyevics has posted comments on this change. ( http://gerrit.cloudera.org:8080/22165 )
Change subject: IMPALA-13648: Implement a decoder and an encoder for Byte Stream Split encoding ...................................................................... Patch Set 36: (2 comments) http://gerrit.cloudera.org:8080/#/c/22165/36/be/src/benchmarks/parquet-byte-stream-split-benchmark.cc File be/src/benchmarks/parquet-byte-stream-split-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/22165/36/be/src/benchmarks/parquet-byte-stream-split-benchmark.cc@563 PS36, Line 563: DATA_BATCH_SIZE > I think we should only use DATA_BATCH_SIZE when generating the data, not wh Done http://gerrit.cloudera.org:8080/#/c/22165/36/be/src/benchmarks/parquet-byte-stream-split-benchmark.cc@592 PS36, Line 592: DATA_BATCH_SIZE > See L563. Done -- To view, visit http://gerrit.cloudera.org:8080/22165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icea60894ae22b8ddb7616aeda6d69012cc69972c Gerrit-Change-Number: 22165 Gerrit-PatchSet: 36 Gerrit-Owner: Gabriella Gyorgyevics <ggyorgyev...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabriella Gyorgyevics <ggyorgyev...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 13:23:44 +0000 Gerrit-HasComments: Yes
