Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22422 )
Change subject: IMPALA-13703: Cancel running queries before shutdown deadline ...................................................................... Patch Set 9: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22422/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22422/8//COMMIT_MSG@16 PS8, Line 16: cancel any remaining running queries within a configurable timelimit > The idea is to cancel queries only near the end of the graceful shutdown de Ah, I misread this as starting cancelation after shutdown_query_cancel_period_s. When I re-read it I think you've described it correctly. http://gerrit.cloudera.org:8080/#/c/22422/8/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22422/8/be/src/service/impala-server.cc@328 PS8, Line 328: "down process. If this duration elapses after the shut down process is started, " > Done Ack http://gerrit.cloudera.org:8080/#/c/22422/8/be/src/service/impala-server.cc@499 PS8, Line 499: > I think the idea is to cancel queries only near the end of the graceful shu Ack -- To view, visit http://gerrit.cloudera.org:8080/22422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cac2e100d329644e21fdceb0b23901b08079130 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 9 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2025 17:08:43 +0000 Gerrit-HasComments: Yes
