Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22422 )
Change subject: IMPALA-13703: Cancel running queries before shutdown deadline ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/22422/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22422/8//COMMIT_MSG@16 PS8, Line 16: cancel any remaining running queries within a configurable timelimit This is a substantial change to shutdown. Queries that might have completed successfully during the graceful shutdown may now be cancelled instead. How did you arrive at 20% of the prior graceful shutdown time to start cancelling queries? http://gerrit.cloudera.org:8080/#/c/22422/8/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22422/8/be/src/service/impala-server.cc@328 PS8, Line 328: "Default time limit in seconds for the shut " This line wasn't too long, why the change in formatting? http://gerrit.cloudera.org:8080/#/c/22422/8/be/src/service/impala-server.cc@499 PS8, Line 499: constexpr double SHUTDOWN_CANCEL_MAX_RATIO = 0.2; Why have this guard? I'd think any value less than the shutdown deadline could still be useful. -- To view, visit http://gerrit.cloudera.org:8080/22422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cac2e100d329644e21fdceb0b23901b08079130 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 8 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 22:25:19 +0000 Gerrit-HasComments: Yes
