Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22437 )
Change subject: IMPALA-13033: support parsing thrift profiles downloaded from WebUI ...................................................................... Patch Set 2: (3 comments) The commit message needs to be corrected. Also, please resolve the existing comments. There are multiple JIRAs related to this reported by Riza Suminto, Quanlong Huang and Abhishek Rawat. So, please make sure to search before creating new ones. IMPALA-11288 - Support decoding Impala profiles in the Web UI IMPALA-12955 - impala-profile-tool depends on unused so files IMPALA-12956 - Provide a summary output for impala-profile-tool The profile tool was also reported to have some redundant .so files IMPALA-12955, requiring cleanup. And there are compatibility issues to keep in mind before implementing other new changes. http://gerrit.cloudera.org:8080/#/c/22437/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22437/2//COMMIT_MSG@11 PS2, Line 11: JIRA no need to mention JIRA http://gerrit.cloudera.org:8080/#/c/22437/2//COMMIT_MSG@11 PS2, Line 11: parse thrift format fails to parse the downloaded thrift profile from the webUI http://gerrit.cloudera.org:8080/#/c/22437/2//COMMIT_MSG@12 PS2, Line 12: parse thrift format profiles webUI's thrift profle, not "parsing" the thrift format -- To view, visit http://gerrit.cloudera.org:8080/22437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iced6dd189aebd0f61ae6cb1bfac7f9dae31c6a4e Gerrit-Change-Number: 22437 Gerrit-PatchSet: 2 Gerrit-Owner: Anshula Jain <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2025 13:09:55 +0000 Gerrit-HasComments: Yes
