Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/22249/8/be/src/scheduling/cluster-membership-mgr.h File be/src/scheduling/cluster-membership-mgr.h: http://gerrit.cloudera.org:8080/#/c/22249/8/be/src/scheduling/cluster-membership-mgr.h@115 PS8, Line 115: ExecutorGroup all_coordinators; This is an optimization to avoid having to iterate all backends to construct the list of coordinators? http://gerrit.cloudera.org:8080/#/c/22249/8/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22249/8/be/src/scheduling/cluster-membership-mgr.cc@202 PS8, Line 202: _removeCoordIfExists(state, be); Why remove and re-add, rather than add only if it's absent or make AddExecutor idempotent? Concurrency issue? -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2025 21:41:36 +0000 Gerrit-HasComments: Yes
