Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22249/7/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/22249/7/be/src/scheduling/admission-controller.cc@2271 PS7, Line 2271: *membership_snapshot->all_coordinators.get() I think I prefer the old method than the new one. The old method is clear, that is will always create a new copy of ExecutorGroup. The ownership of *all_coordinators is not clear in this way. What if shared_ptr all_coordinators is reset after L2271 and before 2303? I understand membership_snapshot is unlikely to change after cluster_membership_mgr_->GetSnapshot(), but it bugs me. ExecutorGroup does not have copy assign constructor. Maybe compiler implicitly create one? http://gerrit.cloudera.org:8080/#/c/22249/7/be/src/scheduling/cluster-membership-mgr.h File be/src/scheduling/cluster-membership-mgr.h: http://gerrit.cloudera.org:8080/#/c/22249/7/be/src/scheduling/cluster-membership-mgr.h@115 PS7, Line 115: std::shared_ptr<ExecutorGroup> Can this just be ExecutorGroup and not shared_ptr? -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 01:40:51 +0000 Gerrit-HasComments: Yes
