Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/22186 )
Change subject: IMPALA-13335: ignore duplicate ‘X-Forwarded-For’ headers ...................................................................... Patch Set 4: (1 comment) Thanks for the quick review http://gerrit.cloudera.org:8080/#/c/22186/3/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/22186/3/be/src/transport/THttpServer.cpp@177 PS3, Line 177: // Only set the origin field the first time that we see the 'X-Forwarded-For' header. > This results in setting origin_ only on the first instance of X-Forwarded-F Thanks, yes, this is the whole point of the change, and I did not explain it. -- To view, visit http://gerrit.cloudera.org:8080/22186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee7b452842aa391d285bd445d6a9e6cbbedd7fbb Gerrit-Change-Number: 22186 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2025 20:56:37 +0000 Gerrit-HasComments: Yes
