Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22186 )
Change subject: WIP: IMPALA-13335: ignore duplicate ‘X-Forwarded-For’ headers ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22186/1/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/22186/1/tests/hs2/test_hs2.py@1210 PS1, Line 1210: n flake8: E713 test for membership should be 'not in' http://gerrit.cloudera.org:8080/#/c/22186/1/tests/hs2/test_hs2.py@1212 PS1, Line 1212: def get_user_custom_headers(): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/22186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee7b452842aa391d285bd445d6a9e6cbbedd7fbb Gerrit-Change-Number: 22186 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 07 Dec 2024 00:43:26 +0000 Gerrit-HasComments: Yes
