Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22336 )
Change subject: IMPALA-13668: Add default_test_protocol parameter to py.test ...................................................................... Patch Set 2: Code-Review+1 (1 comment) This is looking good to me. I'm willing to go to +2 unless others have comments. http://gerrit.cloudera.org:8080/#/c/22336/1/tests/custom_cluster/test_parquet_max_page_header.py File tests/custom_cluster/test_parquet_max_page_header.py: http://gerrit.cloudera.org:8080/#/c/22336/1/tests/custom_cluster/test_parquet_max_page_header.py@63 PS1, Line 63: self.create_impala_clients() > > When do we need to create a new client for customer cluster tests? Cool, it doesn't really impact this review. -- To view, visit http://gerrit.cloudera.org:8080/22336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9165ea220b2c83ca36d6e68ef3b88b128310af23 Gerrit-Change-Number: 22336 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 23 Jan 2025 18:54:43 +0000 Gerrit-HasComments: Yes
