Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22336 )
Change subject: IMPALA-13668: Add default_test_protocol parameter to py.test ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/22336/1/tests/conftest.py File tests/conftest.py: http://gerrit.cloudera.org:8080/#/c/22336/1/tests/conftest.py@57 PS1, Line 57: DEFAULT_TEST_PROTOCOL = 'beeswax' > If we made it possible to set this via an environment variable, it would ma ACK. Will update. http://gerrit.cloudera.org:8080/#/c/22336/1/tests/custom_cluster/test_parquet_max_page_header.py File tests/custom_cluster/test_parquet_max_page_header.py: http://gerrit.cloudera.org:8080/#/c/22336/1/tests/custom_cluster/test_parquet_max_page_header.py@63 PS1, Line 63: self.create_impala_clients() > Orthogonal to the change: When do we need to create a new client for custom Impala custom cluster tests are very liberal. Some need to establish connections to run queries, others just care about starting cluster with specific combination of flag and verify through metrics or logs. Hence, we have peculiar pattern like this TestParquetMaxPageHeader. I did have discussion with Quanlong about adding setup_method() in ImpalaTestSuite. That may or may not be relevant for CustomClusterTestSuite. https://gerrit.cloudera.org/c/20131/31/tests/metadata/test_event_processing_base.py#145 -- To view, visit http://gerrit.cloudera.org:8080/22336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9165ea220b2c83ca36d6e68ef3b88b128310af23 Gerrit-Change-Number: 22336 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 23 Jan 2025 18:33:43 +0000 Gerrit-HasComments: Yes
