Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20169 )
Change subject: PROTOTYPE: Put all thrift-generated python code into the impala_thrift_gen package ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/20169/9/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20169/9/common/thrift/CMakeLists.txt@247 PS9, Line 247: # This generates hive_metastore.thrift in the $THIRDPARTY_THRIFT_DIR. The two : # modification are: : # 1. Set the impala_thrift_gen python namespace : # 2. Rearranges the fb303 reference so that it doesn't have the share/fb303/if : # directory structure > Will the generated code differ slightly if we do this modification over hiv The generated Python code will be different. The difference is purely about the package name, so it impacts some import statements and places that use absolute names. Here's an example of some diffs for the generated hive_metastore code: -import fb303.FacebookService +import impala_thrift_gen.fb303.FacebookService ... -class Iface(fb303.FacebookService.Iface): +class Iface(impala_thrift_gen.fb303.FacebookService.Iface): This doesn't impact the wire protocol / messages, so it doesn't matter to how we interact with services. The generated C++ and Java code is unchanged, so this won't impact Impala itself. -- To view, visit http://gerrit.cloudera.org:8080/20169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0 Gerrit-Change-Number: 20169 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2025 21:24:37 +0000 Gerrit-HasComments: Yes
