Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20169 )
Change subject: PROTOTYPE: Put all thrift-generated python code into the impala_thrift_gen package ...................................................................... Patch Set 9: (1 comment) I'm OK with impala_thrift_gen. Just have one concern. http://gerrit.cloudera.org:8080/#/c/20169/9/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20169/9/common/thrift/CMakeLists.txt@247 PS9, Line 247: # This generates hive_metastore.thrift in the $THIRDPARTY_THRIFT_DIR. The two : # modification are: : # 1. Set the impala_thrift_gen python namespace : # 2. Rearranges the fb303 reference so that it doesn't have the share/fb303/if : # directory structure Will the generated code differ slightly if we do this modification over hive_metastore.thrift? Or the result is the same? Will it impact Impala RPC against HMS in any way? -- To view, visit http://gerrit.cloudera.org:8080/20169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0 Gerrit-Change-Number: 20169 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2025 18:59:18 +0000 Gerrit-HasComments: Yes
