Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22216 )
Change subject: IMPALA-11265: Part3: Remove redundancy of file descriptors in coordinators ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22216/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22216/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@442 PS5, Line 442: hdfsTable_.load(reuseMetadata, msClient, msTable_, reason, catalogTimeline); Would it be possible to set a No-op file metadata loader for the HdfsTable and invoke IcebergFileMetadataLoader directly? This way the underlying 'hdfsTable_' would be empty and all files would come from the IcebergContentFileStore. This would also avoid file descriptor duplication in LocalCatalog, and would be a step toward getting rid of the inner HdfsTable. -- To view, visit http://gerrit.cloudera.org:8080/22216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c245d907baf1e46cb39d046c544bf50b37d581 Gerrit-Change-Number: 22216 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2025 17:15:46 +0000 Gerrit-HasComments: Yes
