Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22216 )
Change subject: IMPALA-11265: Part3: Remove redundancy of file descriptors in coordinators ...................................................................... Patch Set 5: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22216/5/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: PS5: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new optional fields can be added. http://gerrit.cloudera.org:8080/#/c/22216/5/common/thrift/CatalogObjects.thrift@341 PS5, Line 341: 1: required binary file_metadata Modifying/adding this required field might break the compatibility between impalad and catalogd/statestore during upgrade -- To view, visit http://gerrit.cloudera.org:8080/22216 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c245d907baf1e46cb39d046c544bf50b37d581 Gerrit-Change-Number: 22216 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2025 08:48:24 +0000 Gerrit-HasComments: Yes
